Variants: allow registering callbacks for variant changes #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlinND
force-pushed
the
set-variant-cb
branch
from
c9cac9e
to
ced0387
Compare
Consistent with e.g. `dr.scoped_set_flag()`
merlinND
force-pushed
the
set-variant-cb
branch
from
ced0387
to
6ca2661
Compare
merlinND
commented
Oct 29, 2024
wjakob
reviewed
Nov 9, 2024
| @@ -44,6 +44,10 @@ PyObject *mi_dict = nullptr; | |||
| /// Current variant (string) | |||
| nb::object curr_variant; | |||
|
|
|||
| /// Set of user-provided callback functions to call when switching variants | |||
| PyObject *variant_change_callbacks; | |||
There was a problem hiding this comment.
Why is this not an std::set or at least an nb::object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @njroussel.
Currently, upon each variant change, we explicitly reload the custom Python integrators shipped in
mitsuba.python.ad.integrators.Users don't have access to such a mechanism.
By allowing users to register callbacks, they can now implement module loading & reloading for their custom Python plugins.
In the future, there may be a higher-level way for users to register plugins that will automatically create such a reload callback.
I also added an alias
scoped_set_varianttovariant_contextso that it matchesdr.scoped_set_flag().Testing
Added a unit test check.
Checklist
cuda_*andllvm_*variants. If you can't test this, please leave below