New sunsky emitter plugin
#1491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modify resource path to match that
Also fix gather with index out of bounds
Due to the new `ContinuousDistribution` being built with empty pdf.
rtabbara
reviewed
Feb 13, 2025
| spectral or RGB mode, if the final output is an sRGB image, it can happen that | ||
| it contains negative pixel values or be over-saturated. These results are left | ||
| un-clamped to let the user post-process the image to their liking, without | ||
| loosing information. |
There was a problem hiding this comment.
Suggested change
| loosing information. | |
| losing information. |
rtabbara
reviewed
Feb 13, 2025
| FloatStorage params = dr::gather<FloatStorage>(tgmm_tables, indices[mixture_idx] + param_indices); | ||
|
|
||
| // Apply lerp factor to gaussian weights | ||
| //dr::scatter_reduce(ReduceOp::Mul, params, (FloatStorage)lerp_factors[mixture_idx], gaussian_weight_idx); |
There was a problem hiding this comment.
Can this commented out code be removed?
rtabbara
reviewed
Feb 13, 2025
| callback->put_parameter("to_world", *m_to_world.ptr(), +ParamFlags::NonDifferentiable); | ||
| } | ||
|
|
||
| void parameters_changed(const std::vector<std::string> & /*unused*/) override { |
There was a problem hiding this comment.
Should we be filtering on what to update based on the keys passed? e.g. I don't think all updates necessarily require us to update the TGMM?
Speierers
reviewed
Feb 20, 2025
Comment on lines
+79
to
+82
| template <typename Value> | ||
| MI_INLINE Point<Value, 2> from_spherical(const Vector<Value, 3> &v) { | ||
| return { dr::atan2(v.y(), v.x()), dr::unit_angle_z(v) }; | ||
| } |
There was a problem hiding this comment.
I keep re-implementing this function. Would it make sense to move it to math.h instead and expose it with Python bindings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1473. Its content is very similar to the original PR, but has a refactoring/formatting passes.
The dataset generation code (originally commented code in #1473) was refactored, packaged and moved to the
resources/datasubmodule.resources/datasubmodule` must be updated accordinglyAgain, credits to @matttsss for this excellent work.