Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set GL_DEPTH_BUFFER_BIT when blitting the depth buffer to the screen. #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set GL_DEPTH_BUFFER_BIT when blitting the depth buffer to the screen. #126

wants to merge 2 commits into from

Conversation

LukasRuppert
Copy link

Hi, I just had a look through the code and found what looks like a simple copy-paste bug.
When blitting to the screen, the stencil bit would be set instead of the depth buffer bit.

@wjakob wjakob force-pushed the master branch 11 times, most recently from e9c6fc9 to 0f47fe0 Compare October 27, 2022 21:06
@LukasRuppert LukasRuppert force-pushed the fix_deph_buffer_blit branch 2 times, most recently from 6c85fd3 to 2b9f30a Compare November 4, 2022 09:57
@LukasRuppert
Set GL_DEPTH_BUFFER_BIT when blitting the depth buffer to the screen.
b17b828 
(Fixes a copy-paste bug, previously the GL_STENCIL_BUFFER_BIT was being set.)
@LukasRuppert
Disable blitting depth or stencil buffers to the screen if multisampl…
de3221f 
…ing is enabled in the texture.

(Blitting a multisampled texture into a single-sample screen results in a GL_INVALID_OPERATION.)
Should there be a warning if blitting is not possible?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LukasRuppert