Multiple small improvements #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As TextArea::m_selectable field is a bool, it makes sense for TextArea::is_selectable() and TextArea::set_selectable() methods to return and accept bool.
It's enough to clear m_tab_offsets once in this context.
TextArea::draw() checks there's a selected area before drawing highlighted background. However, there's a duplicate condition `m_selection_end != Vector2i(-1)` in this check, presumably due to a typo. Let's do this check properly, using the same rules as in TextArea::keyboard_event().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextArea::draw() checks there's a selected area before drawing highlighted background. However, there's a duplicate condition
m_selection_end != Vector2i(-1)in this check, presumably due to a typo. Let's do this check properly, using the same rules as in TextArea::keyboard_event().As TextArea::m_selectable field is a bool, it makes sense for TextArea::is_selectable() and TextArea::set_selectable() methods to return and accept bool.
Also it's enough to clear m_tab_offsets once in TabWidgetBase::perform_layout().