Removed unnecessary assets and imports. #58
Conversation
|
Share feedback for current pull request, and if it's fine than please do me a favor merge it in oct 1-2 when hacktoberfest starts so that i can claim merge request. |
✅ Deploy Preview for parthmittal ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
You also have to remove their imports from src/assets/index and thereby from constants/index
The current ones that you have removed are not exhaustive. There are more to be removed. The best way to identify that is to check the two files I mentioned above.
If the file exists in assets but is not imported in assets/index - remove it
If the file is imported but is then not used in constants/index - remove it
There was a problem hiding this comment.
Don't think this should be removed either.
There was a problem hiding this comment.
okayy so i'm changing everything and creating a new pr soon
There was a problem hiding this comment.
Don't make a new PR. You can do the changes here on the same branch. In any open source repo, you might receive comments on the PR, after multiple iterations also. That would be inconvenient if every comment results in a new PR. So you can continue on the same one.
issue #57