Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/weather categories #626

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/weather categories #626

wants to merge 3 commits into from
+834 −2

Conversation

Spookyguy
Copy link

No description provided.

@Spookyguy Spookyguy force-pushed the feature/weather_categories branch from dbd5e80 to 39e68bb Compare January 13, 2025 05:26
@mivek mivek linked an issue Jan 17, 2025 that may be closed by this pull request
Computing weather categories #624
Open
@Spookyguy Spookyguy force-pushed the feature/weather_categories branch from 39e68bb to cc17334 Compare January 17, 2025 12:18
@Spookyguy Spookyguy force-pushed the feature/weather_categories branch from cc17334 to 0f5a792 Compare January 18, 2025 18:22
@Spookyguy Spookyguy force-pushed the feature/weather_categories branch 3 times, most recently from 04c8f71 to 6a3ad35 Compare January 21, 2025 06:22
mivek
mivek requested changes Jan 21, 2025
View reviewed changes
Copy link
Owner

@mivek mivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good now.
There are checks failing and the maven verify command is also failing.

metarParser-services/src/test/java/io/github/mivek/service/WeatherCategoryServiceTest.java Outdated Show resolved Hide resolved
@Spookyguy Spookyguy force-pushed the feature/weather_categories branch from 6a3ad35 to 263e2b8 Compare January 22, 2025 08:19
@Spookyguy Spookyguy force-pushed the feature/weather_categories branch 8 times, most recently from 59cca3a to 10cf777 Compare January 23, 2025 06:31
@Spookyguy
Copy link
Author

All checks green now

@Spookyguy Spookyguy force-pushed the feature/weather_categories branch from 10cf777 to 6ed9015 Compare January 23, 2025 09:46
mivek
mivek reviewed Jan 25, 2025
View reviewed changes
Copy link
Owner

@mivek mivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One last question, do you want to add string representation for the weatherCategories ?

@Spookyguy
Copy link
Author

Looks good to me. One last question, do you want to add string representation for the weatherCategories ?

Only if you want me to do that. Personally i don't need it.

@Spookyguy Spookyguy force-pushed the feature/weather_categories branch from 6ed9015 to 4cbe797 Compare January 29, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mivek mivek mivek requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Computing weather categories
2 participants
@Spookyguy @mivek