Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix conflict files and add tests #239

Conversation

OlivierAlbertini
Copy link

Changes Made

Hi,

I forked @Gastonite repo https://github.com/Gastonite/mongo-cursor-pagination
I fixed conflicting files from #60
closes #236

Potential Risks

Potential risks are limited since its covered by tests.

Test Plan

I added tests in order to show that projection works.

Since there is no ci,
Here I show that all tests passed:

Capture d’écran, le 2020-09-22 à 10 11 00
Capture d’écran, le 2020-09-22 à 10 10 48

Checklist

  • I've increased test coverage
  • Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

Please let me know if I can help in anything

@mchockal
Copy link

@OlivierAlbertini : This PR hasn't been merged yet, if I'm not wrong?
The sadness .. :( I'm currently working with a workaround for now.
Could this be merged anytime soon?

@bradvogel
Copy link
Contributor

This hasn't been merged yet. I needs to be rebased on the latest master

@OlivierAlbertini OlivierAlbertini force-pushed the feature/fix-conflict-files-and-add-tests branch from b541e35 to 04b9aec Compare January 13, 2021 19:30
@OlivierAlbertini
Copy link
Author

This hasn't been merged yet. I needs to be rebased on the latest master

done!

@OlivierAlbertini
Copy link
Author

@OlivierAlbertini : This PR hasn't been merged yet, if I'm not wrong?
The sadness .. :( I'm currently working with a workaround for now.
Could this be merged anytime soon?

I still hope =)

also removed spec folder coming from forked project. It shouldn't be migrated here

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini force-pushed the feature/fix-conflict-files-and-add-tests branch from 04b9aec to 8cb240b Compare January 13, 2021 19:35
Signed-off-by: Olivier Albertini <[email protected]>
Signed-off-by: Olivier Albertini <[email protected]>
@bradvogel
Copy link
Contributor

I'm getting test failures in this branch. My commands:

git checkout -b OlivierAlbertini-feature/fix-conflict-files-and-add-tests master
git pull https://github.com/OlivierAlbertini/mongo-cursor-pagination.git feature/fix-conflict-files-and-add-tests
npm ci
npm test

image

@OlivierAlbertini
Copy link
Author

I'm getting test failures in this branch. My commands:

git checkout -b OlivierAlbertini-feature/fix-conflict-files-and-add-tests master
git pull https://github.com/OlivierAlbertini/mongo-cursor-pagination.git feature/fix-conflict-files-and-add-tests
npm ci
npm test

image

Thanks I'm able to reproduce with fresh install, seems related to the rebase (new package versions)
I will check this when I will have some bandwidth

@bradvogel
Copy link
Contributor

Closing due to age. Let me know if you'd like to reopen

@bradvogel bradvogel closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to restrict fields to return when using mongoose
4 participants