-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix conflict files and add tests #239
Feature/fix conflict files and add tests #239
Conversation
2d82343
to
b541e35
Compare
@OlivierAlbertini : This PR hasn't been merged yet, if I'm not wrong? |
This hasn't been merged yet. I needs to be rebased on the latest master |
b541e35
to
04b9aec
Compare
done! |
I still hope =) |
also removed spec folder coming from forked project. It shouldn't be migrated here Signed-off-by: Olivier Albertini <[email protected]>
04b9aec
to
8cb240b
Compare
Signed-off-by: Olivier Albertini <[email protected]>
Signed-off-by: Olivier Albertini <[email protected]>
Thanks I'm able to reproduce with fresh install, seems related to the rebase (new package versions) |
Closing due to age. Let me know if you'd like to reopen |
Changes Made
Hi,
I forked @Gastonite repo https://github.com/Gastonite/mongo-cursor-pagination
I fixed conflicting files from #60
closes #236
Potential Risks
Potential risks are limited since its covered by tests.
Test Plan
I added tests in order to show that projection works.
Since there is no ci,
Here I show that all tests passed:
Checklist
Please let me know if I can help in anything