Add support for thumbnails and videos in changelog list. Also pagination. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Removed a console.log and added a parameter to make the Loom embeds cleaner. Playing with the preview looks good. Merging it now, we can always fix issues forward later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at bringing thumbnails to the list view of the changelog page. How to use it:
In the frontMatter section at the top of each new change log, either set a
thumbnail:URL or avideo:URL. The list view will pick this up and present it. I've set a few for the last 20 or so change log items. Here's an example:video: "https://www.loom.com/embed/3407a37ce1634f51b94b380c40c96306"I also used some chatgpt wizardry to add pagination, as loading too many loom embeds would slow things down. I'm not a web person and can't vet this, so it would be good to get some eyes on this portion especially.