Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up spell checking in PRs #1227

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Set up spell checking in PRs #1227

merged 4 commits into from
Jul 11, 2024

Conversation

austinpray-mixpanel
Copy link
Collaborator

@austinpray-mixpanel austinpray-mixpanel commented Jul 10, 2024 •
edited
Loading

  • Use the spell checker we use in the main monorepo. Works pretty good.
  • Don't enable in PRs yet, just allow people to manually run it on main branch. So we can add obvious false positives to the known word list
  • When fully deployed this will show inline comments about possible spelling suggestions. This is not configured to block PRs.

image

@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 4:09pm

@austinpray-mixpanel austinpray-mixpanel changed the title Check spelling in PRs Set up spell checking in PRs Jul 10, 2024
@austinpray-mixpanel austinpray-mixpanel marked this pull request as ready for review July 10, 2024 23:30
@austinpray-mixpanel austinpray-mixpanel requested a review from a team as a code owner July 10, 2024 23:30
@austinpray-mixpanel austinpray-mixpanel requested review from argenisf and removed request for a team July 10, 2024 23:30
argenisf
argenisf approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@argenisf argenisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @austinpray-mixpanel ,

I'm afraid I'm out of my depth reviewing this but I trust you 😅

Feel free to assign another reviewer on the eng side if you'd like

@austinpray-mixpanel austinpray-mixpanel requested review from a team and junhouse and removed request for a team July 11, 2024 12:34
@austinpray-mixpanel austinpray-mixpanel mentioned this pull request Jul 11, 2024
Merged
matthathornmp
matthathornmp approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@matthathornmp matthathornmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Austin!

@austinpray-mixpanel austinpray-mixpanel merged commit 0c8a82b into main Jul 11, 2024
7 checks passed
@austinpray-mixpanel austinpray-mixpanel deleted the austinpray-mixpanel-patch-3 branch July 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argenisf argenisf argenisf approved these changes

@matthathornmp matthathornmp matthathornmp approved these changes

@junhouse junhouse Awaiting requested review from junhouse junhouse was automatically assigned from mixpanel/interactive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinpray-mixpanel @argenisf @matthathornmp