-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to nextra 3 #1487
Merged
Merged
Convert to nextra 3 #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tiffanyqi
force-pushed
the
tiffany-breadcrumbs
branch
from
October 4, 2024 00:24
96e375d
to
7c24637
Compare
tiffanyqi
force-pushed
the
tiffany-breadcrumbs
branch
from
October 4, 2024 19:35
ea2c767
to
40ee9a8
Compare
tiffanyqi
force-pushed
the
tiffany-breadcrumbs
branch
from
October 4, 2024 19:43
40ee9a8
to
934d0e6
Compare
tiffanyqi
force-pushed
the
tiffany-breadcrumbs
branch
from
October 5, 2024 00:04
934d0e6
to
d08ef30
Compare
tiffanyqi
force-pushed
the
tiffany-breadcrumbs
branch
from
October 9, 2024 18:55
d08ef30
to
204d35e
Compare
tiffanyqi
requested review from
ryancurtis1 and
myronkaifung
and removed request for
a team
October 9, 2024 18:56
myronkaifung
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should prioritize fixing the code syntax highlighting since it makes the SDK pages a lot harder to read.
Not a blocker for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, I was looking into Nextra 3 because of breadcrumb linking, however it turns out that a couple of things are improved if we do it this way.
Pros
Before
After
Changes necessary to use Nextra 3
(this is mostly covered per commit):
Card
andTab
toCards.Card
andTabs.Tab
I'm mostly annoyed that there are so many changes that are not retroactive, but at least it wasn't too bad