Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned Filters ChangeLog #1715

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Pinned Filters ChangeLog #1715

merged 9 commits into from
Jan 15, 2025

Conversation

jennabono-mixpanel
Copy link
Contributor

No description provided.

@jennabono-mixpanel jennabono-mixpanel requested a review from a team as a code owner January 10, 2025 18:06
@jennabono-mixpanel jennabono-mixpanel requested review from catliaw and removed request for a team January 10, 2025 18:06
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:10pm

@catliaw
Copy link
Contributor

catliaw commented Jan 15, 2025

Hey Jenna! I think the screenshot image should be updated because that is the old Pinned Filters UI. It has changed already. I think maybe something like this showing where the filter settings are would be maybe more helpful.
Screenshot 2025-01-15 at 2 25 13 PM
But make sure to use a screenshot from the demo. Not sure who owns the Pinned Filters Demo board and which project it's in.

@catliaw
Copy link
Contributor

catliaw commented Jan 15, 2025

Okay one more nitpicky note. On the screenshot for the UTM Campaign filter, it's showing "Any", but the selected setting is "limit filter values to selection above". Can you Apply the setting and then open the filter settings to take a screenshot? So the screenshot shows what the board filter will look like when the setting is applied. I want to distinguish from the other "Start from none" setting which will show "Any".

Copy link
Contributor

@catliaw catliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the screenshot :D! Looks good! Approved

@catliaw catliaw merged commit 037b4c6 into main Jan 15, 2025
8 checks passed
@catliaw catliaw deleted the jennabono-mixpanel-patch-1 branch January 15, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants