Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Controllers: return from loadSettings() when there's no mapping file #13738

Merged
merged 1 commit into from
Oct 12, 2024
Merged

(fix) Controllers: return from loadSettings() when there's no mapping file #13738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/controllers/legacycontrollermapping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ const QString kControllerSettingsResourcePathSubst = QStringLiteral("%RESOURCE_P
void LegacyControllerMapping::loadSettings(UserSettingsPointer pConfig,
const QString& controllerName) const {
auto mappingFile = QFileInfo(m_filePath);
DEBUG_ASSERT(mappingFile.exists());
if (!mappingFile.exists()) {
// This happens when we start the MIDI Learning Wizard with a new (empty)
// mapping, or when the mapping file has been removed manually by the user.
return;
}
QString controllerPath =
mappingFile.absoluteFilePath()
.replace(pConfig->getSettingsPath(),
Expand Down
Loading