Overview: abort play pos dragging if cursor is relased outside the valid area

[ronso0]

This is an attempt to fix #13732 = simplify aborting accidental position drag

Dragging the play position is allowed only in the valid zone:
overview +-100 px vertically and +-50 px vertically

If the cursor leaves the valid area while dragging:
show a warning cursor
remove the time ruler, restore regular play pos painting

Dragging is aborted only if the release event happens outside.

Also includes a fix: abort play pos dragging if passthrough is enabled.

TODO

• check if devicePixeRatio is relevant here
• make 100% sure that the cursor is reset in all possible situations

[ronso0]

Btw I'd prefer the regular cursor with the usual 'Drop not allowed' icon attached, but that only works for QDrag cursors.
Turning the overview drag into a QDrag is overkill IMO (and I'm not motivated to do that). is no solution: just to get the cursor icon, the QDrag would need to handled by all other potential drop widgets. Dead end.

Besides that I'm pretty satisfied with how this works.
I think in order to get this mergable we need to discuss

• the margin: is a threshold of 50px vertically and 100px horizontally okay? (swapped for vertical overviews)
• the 'Drag not allowed' icon

[spotlesscoder]

looks great :) I will test it later

[spotlesscoder]

I struggle to find the build artifacts every time - a bot that directly links the most common used files (Windows, Linux, Mac installers) after each build directly would be amazing :D

[spotlesscoder]

can you please guide me where to click to download the macOS arm64 build?

[ronso0]

Testing instructions are in the wiki
https://github.com/mixxxdj/mixxx/wiki/Testing

[spotlesscoder]

Thank you :)

[spotlesscoder]

I get this error message

One of the files this plug-in needs cannot be found, please reinstall or contact technical support for assistance.

But nothing is written to the logfile

[ronso0]

Sounds like a macOS error message. Does it print more details?

Did you try to remove Mixxx, then install the CI build again?

[spotlesscoder]

This is what the error looks like on the screen - not sure wether from macOS or mixxx

[spotlesscoder]

Do I also have to remove all my local config data when trying again?

[ronso0]

Let's first check the log file.
But actually this going off-topic, so let's move this discussion to a issue/bug.
Please file a report at https://github.com/mixxxdj/mixxx/issues attach the log file (here's how to find it).

Thank you!

Do I also have to remove all my local config data when trying again?

You can try, sure, we'll see if that makes a difference. The Testing page also has info wrt backups https://github.com/mixxxdj/mixxx/wiki/Testing#backup-settings-and-database, in case you don't want to throw away all you data.

[spotlesscoder]

#13746

[spotlesscoder]

The error still occurs with mixxx-2.6-alpha-106-g26e7afc968.dmg even after deleting the old Mixxx folder

[ronso0]

Okay (not). I have no clue how this relates to this PR tbh. These are only changes to the drag behavior, no new modules or plugins are added.