-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview: abort play pos dragging if cursor is relased outside the valid area #13741
base: main
Are you sure you want to change the base?
Conversation
Btw I'd prefer the regular cursor with the usual 'Drop not allowed' icon attached, but that only works for QDrag cursors. Besides that I'm pretty satisfied with how this works.
|
da253f2
to
d19c8be
Compare
70baa89
to
fae9428
Compare
looks great :) I will test it later |
fae9428
to
0be27d0
Compare
I struggle to find the build artifacts every time - a bot that directly links the most common used files (Windows, Linux, Mac installers) after each build directly would be amazing :D |
can you please guide me where to click to download the macOS arm64 build? |
Testing instructions are in the wiki |
Thank you :) |
I get this error message One of the files this plug-in needs cannot be found, please reinstall or contact technical support for assistance. But nothing is written to the logfile |
Sounds like a macOS error message. Does it print more details? Did you try to remove Mixxx, then install the CI build again? |
Do I also have to remove all my local config data when trying again? |
Let's first check the log file. Thank you!
You can try, sure, we'll see if that makes a difference. The Testing page also has info wrt backups https://github.com/mixxxdj/mixxx/wiki/Testing#backup-settings-and-database, in case you don't want to throw away all you data. |
0be27d0
to
fe428ef
Compare
fe428ef
to
3fc4012
Compare
3fc4012
to
7782585
Compare
The error still occurs with mixxx-2.6-alpha-106-g26e7afc968.dmg even after deleting the old Mixxx folder |
Okay (not). I have no clue how this relates to this PR tbh. These are only changes to the drag behavior, no new modules or plugins are added. |
This is an attempt to fix #13732 = simplify aborting accidental position drag
Dragging the play position is allowed only in the valid zone:
overview +-100 px vertically and +-50 px vertically
If the cursor leaves the valid area while dragging:
show a warning cursor
remove the time ruler, restore regular play pos painting
Dragging is aborted only if the release event happens outside.
Also includes a fix: abort play pos dragging if passthrough is enabled.
TODO