Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Mixxx 2.4 press information / release blogpost #304

Closed

Conversation

JoergAtGithub
Copy link
Member

Early draft of a Mixxx 2.4 press information (which can later be converted into the release blogpost).

Far from complete - just published the PR as base for public discussion.

@JoergAtGithub JoergAtGithub changed the title Mixxx 2 4 press information / release blogpost Mixxx 2.4 press information / release blogpost Aug 12, 2023
content/news/XX-XX-XXXX-mixxx_2_4_features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx_2_4_features.md Outdated Show resolved Hide resolved
Comment on lines 26 to 27
Mixxx 2.4 adds support for setting an explicit leader for sync. Only one deck can be the sync leader, this is set and indicated by the new crown symbol button.
This mode is useful if you work with tracks, with variable BPM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe at another sentence that summarizes the behavior. like "when multiple tracks have variable BPM and sync enabled, all the decks will follow the changing bpm of the sync leader" (obviously we'd need a little more work on the wording here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this mode becomes already relevant with one deck in variable BPM beatgrid.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, haven't looked at the details too closely yet since I have all tracks with const beatgrid anyways.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this feature so I tweaked the text

content/news/XX-XX-XXXX-mixxx_2_4_features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx_2_4_features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx_2_4_features.md Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

Thank you for getting this started.

content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XX-XX-XXXX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
Holzhaus
Holzhaus previously approved these changes Aug 12, 2023
content/news/XXXX-XX-XX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
@JoergAtGithub
Copy link
Member Author

I collected some public available media contacts, where we could send the early media information to:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

@daschuer
Copy link
Member

daschuer commented Dec 2, 2023

Thank you! Would you mind to update https://github.com/mixxxdj/mixxx/wiki/Release-Checklist-2.4.0 accordingly?

@JoergAtGithub
Copy link
Member Author

Thank you! Would you mind to update https://github.com/mixxxdj/mixxx/wiki/Release-Checklist-2.4.0 accordingly?

Done!

@ronso0
Copy link
Member

ronso0 commented Dec 16, 2023

I'll take another look soonish.
The Sync update description needs to be updated (no explicit leader anymore).

@JoergAtGithub
Copy link
Member Author

Feel free, to edit this PR!

content/news/XXXX-XX-XX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XXXX-XX-XX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XXXX-XX-XX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XXXX-XX-XX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
content/news/XXXX-XX-XX-mixxx-2-4-0-features.md Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jan 18, 2024

Note to myself: create a short demo

  • rearrange/hide parameters
  • adjust Meta mapping
  • save
  • load to Quick Effect
  • demo with music?

@JoergAtGithub
Copy link
Member Author

I linked the new Saved Loops video from our YouTube channel, but only the Direct Link button works, but not the embedded player.
@Holzhaus Could you have a look, why the second player instance does not work?

@ywwg ywwg changed the base branch from website to 2.4 February 7, 2024 19:15
@ywwg
Copy link
Member

ywwg commented Feb 7, 2024

repointing at 2.4

@ywwg
Copy link
Member

ywwg commented Feb 8, 2024

@JoergAtGithub any reason not to make this reviewable?

@ronso0
Copy link
Member

ronso0 commented Feb 9, 2024

To prevent accidental merge?

I think we need some custom equivalent to the fixup merge blocker, e.g. by (ab)using a keyword or checkbox in the PR description.

@JoergAtGithub JoergAtGithub marked this pull request as ready for review February 9, 2024 09:45
@JoergAtGithub JoergAtGithub changed the title Mixxx 2.4 press information / release blogpost [Draft] Mixxx 2.4 press information / release blogpost Feb 9, 2024
@ywwg
Copy link
Member

ywwg commented Feb 12, 2024

@JoergAtGithub are you able to address the last notes?

@JoergAtGithub
Copy link
Member Author

@JoergAtGithub are you able to address the last notes?

I'm ill and can't contribute in the momemt, feel free edit it yourself!

@ywwg
Copy link
Member

ywwg commented Feb 13, 2024

closing and opening my own PR, keeping your original commits. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants