Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow just 1 dash in Table delimiter cells (#131) #203

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

pbodnar
Copy link
Collaborator

@pbodnar pbodnar commented Dec 9, 2023

Fixes #131.

In or around [#371](github/markup#371), GFM relaxed constraints on the minimal number of required dashes in table delimiter row.

So we relax the constraints as well. To "compensate" for this change,
we check the format of the delimiter row more thoroughly (although
we still do *not* check number of cells in the delimiter row).
@pbodnar pbodnar self-assigned this Dec 9, 2023
@coveralls
Copy link

Coverage Status

coverage: 94.159% (+0.006%) from 94.153%
when pulling 38e367c on issue-131-support-one-dash-in-delimiter
into fb231b1 on master.

@pbodnar
Copy link
Collaborator Author

pbodnar commented Dec 9, 2023

Leaving this open for community feedback for a few days.

@pbodnar pbodnar merged commit 54f6c21 into master Dec 14, 2023
8 checks passed
@pbodnar pbodnar deleted the issue-131-support-one-dash-in-delimiter branch December 14, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tables GFM-compliant - support less than 3 dashes in delimiters
2 participants