New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Errors in Federation Training Commands and Add Testcases. #183

Merged

miyurud merged 15 commits into miyurud:master from FYP-Auto-Scale-JasmineGraph:train-test

Sep 4, 2023

Collaborator

Ishad-M-I-M commented Sep 1, 2023

Test cases added:

agdr-cust
merge
train

Fixes:

Fix not completing host acknowledgement. ( Read HOST-OK response after sending the IP address of the host).
Install Python 3.8 and use it to run Python scripts which are using stellargraph. ( stellargraph only supports up to Python 3.8).

Additionally, wrote the Python script logs to a mounted location and added a few important log lines.

Ishad-M-I-M added 12 commits

September 1, 2023 22:11


          Add adgr-cust test

32de89c


          Add train test

3e331b9


          Add merge command test

79bda37


          fix incorrect path formation

6cee791


          Update attribute file


          Add response back for merge command

e07abdb


          Fix ERROR connecting in train command

e0e7cdc


          Enable logging in merge python script

e9b733d


          Write python script logs to timestamped files in the mounted location

302d061


          Fix not readingHOST-OK response

72818b0


          Add important log lines

eb6cfbe


          Setup python 3.8 to support current federation training code

dee551c

miyurud requested a review from thevindu-w

September 1, 2023 17:03

Ishad-M-I-M added 2 commits

September 2, 2023 03:39


          Fix testcase rmgr

5dac047


          Fix error in exchanging model weights

43219e5

miyurud reviewed

View reviewed changes

src/server/JasmineGraphInstanceService.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/server/JasmineGraphInstanceService.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/server/JasmineGraphInstanceService.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/server/JasmineGraphInstanceService.cpp Outdated Show resolved Hide resolved

miyurud reviewed

View reviewed changes

src/server/JasmineGraphInstanceService.cpp Outdated Show resolved Hide resolved

miyurud requested changes

View reviewed changes

Owner

miyurud left a comment

I have put some comments. Please address them.

Ishad-M-I-M commented

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

Ishad-M-I-M commented

View reviewed changes

src/server/JasmineGraphInstanceService.cpp Outdated Show resolved Hide resolved

Ishad-M-I-M commented

View reviewed changes

src/server/JasmineGraphInstanceService.cpp Outdated Show resolved Hide resolved

Ishad-M-I-M force-pushed the train-test branch from b4e0eb5 to 8e942a4 Compare

September 4, 2023 03:55


          Apply suggestions from code review

5d4792e

Co-authored-by: Miyuru Dayarathna <[email protected]>

Ishad-M-I-M force-pushed the train-test branch from 8e942a4 to 5d4792e Compare

September 4, 2023 03:57

miyurud approved these changes

View reviewed changes

miyurud merged commit a107a5b into miyurud:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet