add cypher AST #250
add cypher AST #250
Conversation
| @@ -1,6 +1,6 @@ | |||
| cmake_minimum_required(VERSION 3.10) | |||
| project(JasmineGraph) | |||
| set(CMAKE_CXX_STANDARD 11) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
There was a problem hiding this comment.
We use C++ 11 standard currently in JasmineGraph. Is there special reason to change the C++ standard to 17?
There was a problem hiding this comment.
sir, I have to use "any_cast" and "std::any" in the cypher ast, because I have to override the methods of generated parse by antlr4 and those methods use that "std::any". it is a utility which is provided by c++ 17 standards. that's why I used C++ 17 standards.
There was a problem hiding this comment.
This is not a simple change. We have to evaluate the effect of this for the entire project. We should not do standard upgrade unless we assess the essential requirement of doing so, what would be the complications, and the development workload attached to that. So what you are saying is Cypher is dependent on C++ 17?
| RUN apt-get update && apt-get install --no-install-recommends -y default-jre | ||
| RUN curl -O https://s3.amazonaws.com/artifacts.opencypher.org/M23/Cypher.g4 | ||
| RUN curl -O https://www.antlr.org/download/antlr-4.13.2-complete.jar | ||
| RUN java -jar antlr-4.13.2-complete.jar -Dlanguage=Cpp -visitor Cypher.g4 |
There was a problem hiding this comment.
Can we move this entire process of downloading, installing, running, and removing the JVM to pre-requisites image? I do not see a point of doing that here.
| @@ -45,6 +45,12 @@ limitations under the License. | |||
| #include "JasmineGraphFrontEndProtocol.h" | |||
| #include "core/CoreConstants.h" | |||
| #include "core/scheduler/JobScheduler.h" | |||
| #include "antlr4-runtime.h" | |||
| #include "/home/ubuntu/software/jasminegraph/code_generated/antlr/CypherLexer.h" | |||
| #include "/home/ubuntu/software/jasminegraph/code_generated/antlr/CypherParser.h" | |||
There was a problem hiding this comment.
Rather than specifying absolute path here, we should use relative path instead.
| @@ -0,0 +1,1668 @@ | |||
| #include "ASTBuilder.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1,219 @@ | |||
| #include <any> | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1,6 @@ | |||
| #include "ASTInternalNode.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1,19 @@ | |||
| #include "ASTNode.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1 @@ | |||
| #include "ASTLeafNoValue.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1,14 @@ | |||
| #include "ASTNode.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1 @@ | |||
| #include "ASTLeafValue.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1,16 @@ | |||
| #include "ASTNode.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
| @@ -0,0 +1,25 @@ | |||
| #include "ASTNode.h" | |||
There was a problem hiding this comment.
Lets add license header to this file.
|
|
||
| using namespace std; | ||
|
|
||
| string ASTNode::print(int depth, string prefix, bool isLast) const |
There was a problem hiding this comment.
May be good to keep this print function as a support for debugging. However, we should use a logger instead of outputting this to console.
| @@ -0,0 +1,24 @@ | |||
| #include <vector> | |||
There was a problem hiding this comment.
Lets add license header to this file.
add license and print ast in logger
fix issue on a TODO comment of multipartquery grammar
|
merge from jasmineGraph master
|
No description provided.