Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JasmineGraph Frontend Shell #254

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ChandiH
Copy link
Contributor

@ChandiH ChandiH commented Sep 17, 2024

  • implement jasminegraph frontend ui shell ( running in port 7776 )
  • seperate common frontend util functions

@@ -317,182 +308,6 @@ int JasmineGraphFrontEnd::run() {
}
}

/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete these code segments?


for (auto &column : row) {
switch (counter) {
case 0:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of integers used in the switch can we have some constants/enums?

Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put some comments. Please address them all and reply to each of the comments explaining how you addressed them.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 563 lines in your changes missing coverage. Please review.

Project coverage is 1.38%. Comparing base (8c8eb3f) to head (fac0a9b).

Files with missing lines Patch % Lines
src/frontend/ui/JasmineGraphFrontEndUI.cpp 0.00% 361 Missing ⚠️
...rontend/core/common/JasmineGraphFrontendCommon.cpp 0.00% 131 Missing ⚠️
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 29 Missing ⚠️
src/util/Utils.cpp 0.00% 29 Missing ⚠️
src/server/JasmineGraphServer.cpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #254      +/-   ##
=========================================
+ Coverage    1.28%   1.38%   +0.10%     
=========================================
  Files          67      69       +2     
  Lines       13493   14672    +1179     
  Branches     8925    9308     +383     
=========================================
+ Hits          173     203      +30     
- Misses      13118   14268    +1150     
+ Partials      202     201       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
6.0% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants