-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JasmineGraph Frontend Shell #254
base: master
Are you sure you want to change the base?
Conversation
ChandiH
commented
Sep 17, 2024
- implement jasminegraph frontend ui shell ( running in port 7776 )
- seperate common frontend util functions
@@ -317,182 +308,6 @@ int JasmineGraphFrontEnd::run() { | |||
} | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you delete these code segments?
|
||
for (auto &column : row) { | ||
switch (counter) { | ||
case 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of integers used in the switch can we have some constants/enums?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put some comments. Please address them all and reply to each of the comments explaining how you addressed them.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
=========================================
+ Coverage 1.28% 1.38% +0.10%
=========================================
Files 67 69 +2
Lines 13493 14672 +1179
Branches 8925 9308 +383
=========================================
+ Hits 173 203 +30
- Misses 13118 14268 +1150
+ Partials 202 201 -1 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |