Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest updates that changed event markers to be time based caused paths with events to crash on C++.
When doing:
A new vector is created each time m_generatedTrajectory.getEventCommands() is called, meaning that the iterators are not linked. I solved this by storing the eventCommands in a different variable and then getting the begin and end iterators from it. Another solution could maybe be changing PathPlannerTrajectory::getEventCommands to return a constant reference to the events.