Implemented buildAutoChooser() in Python. #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PathPlannerLib
|
The documentation part should be changed to have tabs for different languages to be consistent with the rest of the examples. You should be able to copy one of those examples, remove the C++ tab, and change the code part. Let me know if you need any help with that. |
|
Done. Didn't catch that the first time around, was wondering how the switching worked. |
mjansen4857
requested changes
Mar 13, 2024
| </tabs> | ||
|
|
||
| </snippet> |
There was a problem hiding this comment.
I believe this is a stray closing tag
Suggested change
| </snippet> |
There was a problem hiding this comment.
Is it? That was there before, I simply moved it down. The md originally opened with <snippet id="build-an-auto"> and ended with </snippet> immediately after the java example code.
There was a problem hiding this comment.
Yeah you're right. Forgot that file is different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was already doing this for my team's robotpy code so I figured why not implement it here. As far as my testing extends, it works, I am not 100% sure if I implemented the docs correctly, however.