Mkarg/unable to determine if a 571 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore default value for required parameter Fix cbeust#566
Co-authored-by: Markus KARG <[email protected]>
Fixes cbeust#471 by implementing optional `defaultValueDescription` parameter which overrides the automatic description.
…must not produce different result as existing code relies on current behavior
Before this commit, if you supply a command to a JCommander object and you dont supply a description for the command, then when calling usage() you will see a line of the following format: "<command-name> null" After this commit the string literal "null" will be omitted from the usage() call if you do not supply a description for the command. Fixes cbeust#480
Example for @parameter on setter method
If a default value is assigned to a required parameter on its initialization, JCommander won't throw ParameterException even if no value is given by user. Due to this fix JCommanderTest#requiredFields1Fail did not fail anymore since Args1#verbose was a required parameter with a default value. To distinguish the two cases when a required parameter has no default value and has a default value, this commit removes the default value from Args1#verbose.
* Allow acceptUnknownOption with variableArity VariableArity makes it difficult to decide whether a token belongs to a preceding variableArity Parameter or is a new unknown parameter. This commits makes a variableArity Parameter consume all tokens until it encounters a known option. Fixes: cbeust#377 * Change test to use '=' separator only for new case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test.