Added centering of screen for multiple monitors #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lencioni
added a commit
that referenced
this pull request
Apr 18, 2014
Add centering of screen for multiple monitors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper pull for supporting multiple monitors. Note that while this fixes the issues for modern browsers, IE is only half fixed.
Old behavior:
No matter the browser, if centered, the pop up would be in the center of the first monitor
New behavior on standards browser:
If centered the popup will be on the center of the monitor which your browser is located.
New behavior on internet explorer browser:
If centered the popup will be on the center of the monitor which your browser is located. BUT, it will base the center coordinates off of your primary monitor. So if your monitor where your browser is located is at a different resolution than your primary, it may be slightly off center.