Merge pull request #43 from mkobuolys/ci/example-base-href

ci: update example's base url
mkobuolys · Dec 3, 2023 · a1adc26 · a1adc26
2 parents 828233e + 6a90e76
commit a1adc26
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/deploy-example.yaml b/.github/workflows/deploy-example.yaml
@@ -23,7 +23,7 @@ jobs:
         working-directory: ./example
 
       - name: Build web
-        run: flutter build web --release --web-renderer=canvaskit
+        run: flutter build web --release --web-renderer canvaskit --base-href ./
         working-directory: ./example
 
       - name: Deploy to GitHub Pages

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# NEXT
+
+- ci: update the example's base url for GitHub Pages deployment
+
 # 0.8.0
 
 - feat: add marker tool

diff --git a/example/web/index.html b/example/web/index.html
@@ -14,7 +14,7 @@
     This is a placeholder for base href that will be replaced by the value of
     the `--base-href` argument provided to `flutter build`.
   -->
-  <base href="./">
+  <base href="$FLUTTER_BASE_HREF">
 
   <meta charset="UTF-8">
   <meta content="IE=Edge" http-equiv="X-UA-Compatible">