Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple attributes #21

Merged
merged 5 commits into from
Dec 1, 2014

Conversation

little-dude
Copy link
Contributor

Handle multiple attributes on the same line :

# example/decorator.attibs
test_decorator.fun_test_multiple_attr: fun_one, fun_two
test_decorator.TestMultipleAttr: class_one, class_two
test_decorator.TestMultipleAttr.test_one_and_two: meth_one, meth_two
# example/decorator.py
class TestMultipleAttr:
    def test_one_and_two(self):
        print "Running test_one_and_two"


def fun_test_multiple_attr():
    print "Running fun_test_multiple_attr"

Output :

(env2)./~pinocchio git:namedattr ❯❯❯ nosetests --decorator-file examples/test_decorator.attribs examples/test_decorator.py -a class_one,meth_two -s
Running test_one_and_two
.
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK
(env2)./~pinocchio git:namedattr ❯❯❯ nosetests --decorator-file examples/test_decorator.attribs examples/test_decorator.py -a meth_one,meth_two -s
Running test_one_and_two
.
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK
(env2)./~pinocchio git:namedattr ❯❯❯ nosetests --decorator-file examples/test_decorator.attribs examples/test_decorator.py -a fun_one,fun_two -s
Running fun_test_multiple_attr
.
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK

@little-dude
Copy link
Contributor Author

Just realizing that for each PR, I also push all the commits from previous PR... I'm not totally used to git, should I re-do the PRs with only the relevant commit, or will it be handle automatically if you merge the PR in the order ?

@mkwiatkowski
Copy link
Owner

Just realizing that for each PR, I also push all the commits from previous PR... I'm not totally used to git, should I re-do the PRs with only the relevant commit, or will it be handle automatically if you merge the PR in the order ?

Yes, it will be handled, but in general when you have separate features it's good to put them in separate branches all derived from master. This way I'd be able to accept them separately.

Another thing is that those branches are all based on a very old commit. It would be easier if this was based on master. I'll do the merge manually now, but keep that in mind in the future.

@mkwiatkowski mkwiatkowski merged commit 91ffe4c into mkwiatkowski:master Dec 1, 2014
@mkwiatkowski
Copy link
Owner

BTW, I just noticed another issue with this plugin: #22, only on Python3 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants