-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Haiku support #56
base: devel
Are you sure you want to change the base?
Conversation
Thanks for sharing this pull request with me and apologies for taking so long to get back. I don't have the Haiku experience to review or maintain but I am willing to maintain a Before I do this I would like to know if you are interested in supporting Haiku via premake when premake5 comes available (maybe it has by now)? |
Oh I didn't reply yet… you're not the only one lagging ;-) Not sure why you want to keep this in a separate branch… We still have premake 4.4 in haikuports. Looks like 5 is now alpha, I guess someone will update the recipe… |
I managed to build premake 5 alpha13 (alpha14 has a missing file). |
But of course it won't work… |
I actually installed HaikuOS onto virtualbox tonight and attempted to compile it. I noticed this PR uses the deprecated Scons approach to compiling. Unfortunately, it also failed to build tests with link errors: I haven't looked at the source code yet. Is there any will to get this cleaned up? I would consider merging it if the code was of a maintainable quality and just worked for anyone who wanted to build it and its tests. The first order of business is moving over to the existing Premake system. Let me know. |
I got premake working but I still have to squash the PR… It's possible it doesn't link with the C++ library by default. You might want to try to build after running |
It doesn't work on my fresh install. Let me know when premake support is in there and it works from a fresh checkout and provides build instructions that works from a fresh install and I'll check it out. |
This PR has merge conflicts and doesn’t build, and has had no comments in a week. In the interest of keeping NFD’s github page current, I’d like to hear a commitment to move this forward with a specific timeframe, or we can close this and try again later with a different PR. |
Well I spent the time rebasing the PR on premake… time spent somewhere is not spent on project that's already been waiting for months. I'll rebase and see. Wait, which version did you install, beta, nightly? Did you take the gcc2h or a 64bit one? |
I rebased but I can't get premake 5 alpha13 to work so I can't add the haiku-specific part yet: I'll try to make an alpha14 package with my patches… |
I finally managed to get a usable premake5 package… but now I have to implement |
It should build now with gcc > 2.95 (I suppose you didn't use the official gcc2 hybrid image which is why you had the missing new()), but I'd still like to get gcc2 working. However it seems premake itself uses options that it doesn't understand properly. |
I'll check it out. What are the exact commands I should type in after doing a fresh install of the OS to get this fully built? |
On latest nightly (gcc2h, I don't think the buildbot generated a premake package for the other ones) you should be able to:
|
The members of the strucs where used after the looper deleted itself (via PostMessage(B_QUIT_REQUESTED)), resuting in bad data. So we copy the struct instead of getting a reference, before deleting the looper.
We previously only returned the file names, not the full paths.
Note we want x86 build by default. Only gcc>2 build works for some reason, I suppose premake doesn't care about gcc2 and uses incompatible args, but we do.
I noticed ImHex that I want to port actually uses this as a git submodule… |
Oddly premake munges all the |
This fixes and upstreams a port by @puckipedia done some years ago.
Didn't check the premake stuff yet (it seems we have a recipe for 4.4 but not 5 yet), but the Scons-built test do work.