-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made compressed image handling smoother, removed hardcoding #40
base: master
Are you sure you want to change the base?
Conversation
Thank you for the Pull Request. Will test this once my bandwidth allows me, probably this weekend or the next. |
This should address #36 and #38 as the script hanging behavior is consistent with the hardcoded topics, and address #37 by enabling regular Image to mp4. One limitation to note is that I am testing with CompressedImage files which have a reference to the encoding in the format field, which is not standard. I have not tested with those that specify only compression format, but that should be addressable with additional flags or elif cases. |
The script hanging behaviour as captured in the 2 aforementioned issues is unfortunately still not resolved with the modifications introduced. Steps To Reproduce 📚
cd $HOME git clone https://github.com/cardboardcode/virtual_camera.git --depth 1 --single-branch && cd virtual_camera
test.mp4cd ~/virtual_camera/data && ln -sf test.mp4 input_data cd ~/virtual_camera && bash scripts/0_build_docker_image.bash bash scripts/1_create_docker_container.bash This publishes
cd $HOME && git clone https://github.com/gt-marine-robotics-group/rosbag2video.git --branch master --depth 1 --single-branch && cd rosbag2video
source /opt/ros/humble/setup.bash && ros2 bag record /virtual_camera/image_raw python3 ros2bag2video.py -t /virtual_camera/image_raw <generated_rosbag2_bag_file_folder_name> Expected Behaviour 🟢Script does not hang and generates Actual Behaviour 🔴Script still hangs. |
I will look into this when I get a chance, thanks! |
nice to see some activity. thanks for the pull requests. |
Hi, I added handling for compressed images that does not involve hardcoding. Hardcoding for video rendering of Image types was also fixed. Topic name argument should work now. Also made images be saved in a separate directory to reduce likelihood of unintended deletion of existing png images. Added a flag to save images.