Implemented Dockerisation + Direct Sqlite3 Extraction for ROS 2 Bag Folders #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r .db3 file directly for ROS2 bag files. Signed-off-by: Bey Hao Yun <[email protected]>
…alues. Yet to make it more user-friendly. Signed-off-by: Bey Hao Yun <[email protected]>
…eo.py. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
…y inputs. Adhering to parent repo's argument format. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
… unused fps commandline argument. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
…ker. Verified to run successfully with local ROS 1 bag file. Signed-off-by: Bey Hao Yun <[email protected]>
…mes. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
…g function. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
…nerating the video. Signed-off-by: Bey Hao Yun <[email protected]>
…ing in docker with upgraded ROS 2 script. Signed-off-by: Bey Hao Yun <[email protected]>
…ntains messages that are compressed or not. Signed-off-by: Bey Hao Yun <[email protected]>
Signed-off-by: Bey Hao Yun <[email protected]>
|
Thanks for all the work. looking forward for your pull request |
…plemented with argument flag in place. Signed-off-by: gary.bey <[email protected]>
…on of rosbag2 file metadata. Signed-off-by: gary.bey <[email protected]>
…ld fix/hack. Signed-off-by: gary.bey <[email protected]>
Signed-off-by: gary.bey <[email protected]>
Signed-off-by: gary.bey <[email protected]>
…eption. Signed-off-by: gary.bey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Pull Request 🔖
This aims to address issues #21 and #22.
It addresses issue 22 by allowing
rosbag2video.pyandros2bag2video.pyto run within docker containers. By doing so, there should no longer any environment conflict issues regardless of what version of x86 Ubuntu or Linux-based Operating system the user may be running the scripts in.rosbag2video.pyis currently based in ROS 1 Noetic. 🟢ros2bag2video.pyis currently based in ROS 2 Humble. 🟢It addresses issue 21 by revamping the approach of saving image to read the ROS 2 bag folder
.db3file and its correspondingmetadata.yamlfile directly. By doing so, this would prevent messages from being dropped, causing the hanging script behaviour.Summary 📚
README.mdto reflect the new implement and docker features.Dockerfile.ros1andDockerfile.ros2files in root.ros2bag2video.pywith direct extraction from sqlite3, instead of using previous approach of reading from ROS 2 topic.