Protection level for Texture2D variable defined in TransferFunction.cs #267
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erFunction.cs from private to protected. This change will allow for making 3rd party changes or customizations to transfer function creation as well as texture processing.
|
Thank you for the PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the protection level for Texture2D variable defined in TransferFunction.cs from private to protected. This change will allow for making 3rd party changes or customizations to transfer function creation as well as texture processing.
Without this change, I can only create a scriptable instance of TransferFunction in my own implementation, but Texture2Ds that I define and make changes to, do not get propagated to UnityVolumeRendering's workflow. I see a GetTexture() but did not find any SetTexture() that allows injecting my own texture.
Using a protected Texture2D variable will allow for inheriting the variable from TransferFunction class.
#266