Monitor subprocess #431
Open
Monitor subprocess #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-cty
requested changes
Jul 30, 2023
There was a problem hiding this comment.
Hello,
Thanks for the contribution. Can you add a documentation in https://github.com/mlco2/codecarbon/blob/master/docs/edit/usage.rst ?
| @@ -73,17 +89,18 @@ def init(): | |||
| @click.option( | |||
| "--api/--no-api", default=True, help="Choose to call Code Carbon API or not. (yes)" | |||
There was a problem hiding this comment.
Note to myself : document the "--no-api" parameter and remove the beta mention for the API.
| measure_power_secs=measure_power_secs, | ||
| api_call_interval=api_call_interval, | ||
| save_to_api=api, | ||
| tracking_mode="process", |
There was a problem hiding this comment.
Not sure if it works with process. It need a test with a process that consume RAM to see the difference with machine because process does not work for GPU and CPU yet.
|
@benoit-cty besides documentation, is there any other blocker on this PR ? |
It has to be tested to ensure it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #382
This PR adds functionality to the
codecarbon monitorcommand.When you run
codecarbon monitor, the previous behavior is kept the same.When you run
codecarbon monitor -- some positional --arguments -lah, the positional arguments are ran as a subprocess and monitored with the optiontracking_mode="process".