-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate data and API : Tickets [507] & [299] #508
base: master
Are you sure you want to change the base?
Conversation
prompts for Organisation Teams Project and Experiment Creations , uses typer instead of click
allows to create and list organisations, projects and teams from the CLI
allows easier testing
- Navig Bar created - Home Page - Admin Page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its very nice to add those 3 tabs ! On a side note I think we need to decide where to put the python queries to the api between dashboard/data/data_loader.py and codecarbon/core/api_client.py
) | ||
if existing_organization: | ||
raise HTTPException( | ||
status_code=404,detail=f"the organization name {organization.name} is already existed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f"the organization named {organization.name} already exists"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just corrected that anomaly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f"the project named {project.name} of team {project.team_id} already exists"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just corrected that anomaly
) | ||
if existing_team: | ||
raise HTTPException( | ||
status_code=404,detail=f"the team name {team.name} of that organization {team.organization_id} is already existed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f"the team name {team.name} of organization {team.organization_id} is already exists"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just corrected that anomaly
prompts for Organisation Teams Project and Experiment Creations , uses typer instead of click
allows to create and list organisations, projects and teams from the CLI
allows easier testing
…into feat/rework_cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encounter error when running SQL Script.
|
||
--RAISE NOTICE '------- START -------'; | ||
RAISE NOTICE 'The rows affected by A=%',a_count; | ||
RAISE NOTICE 'Delete experiments which contains any runs affected' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAISE NOTICE 'Delete experiments which contains any runs affected' | |
RAISE NOTICE 'Delete experiments which contains any runs affected'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix stored procedure
|
||
|
||
RAISE NOTICE '--------------'; | ||
RAISE NOTICE 'Delete projects which contains any experiments affected' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAISE NOTICE 'Delete projects which contains any experiments affected' | |
RAISE NOTICE 'Delete projects which contains any experiments affected'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix stored procedure
|
||
|
||
RAISE NOTICE '--------------'; | ||
RAISE NOTICE 'Delete teams which contains any project affected ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAISE NOTICE 'Delete teams which contains any project affected ' | |
RAISE NOTICE 'Delete teams which contains any project affected '; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix stored procedure
|
||
|
||
RAISE NOTICE '--------------'; | ||
RAISE NOTICE 'Delete organizations which contains any teams affected' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAISE NOTICE 'Delete organizations which contains any teams affected' | |
RAISE NOTICE 'Delete organizations which contains any teams affected'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix stored procedure
|
||
DROP TABLE temp_table; | ||
|
||
COMMIT; -- end of transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got an error :
ERROR: invalid transaction termination
CONTEXT: PL/pgSQL function spcc_purgeduplicatedata() line 115 at COMMIT
SQL state: 2D000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix stored procedure
- Admin Page which allow to create an organization into database.
[507] : stored procedure which delete all duplicate data and organization unused
[299] : Prevent duplicate entry on API