Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fixed wrong return type hint and updated doc string #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MyGodItsFull0fStars
Copy link
Contributor

Hi, I made some changes to the stop_task(...) function of the BaseEmissionTracker class.

I changed the return type from float to the actual return type EmissionsData.
This was probably an oversight, as in almost every other function the return type is a float.

I also changed the return type in the doc-string from None to the actual one.

@benoit-cty
Copy link
Contributor

Hello,
Thanks, I think it's a good idea. It's a breaking change so it needs to be put in a major release, and do the same things on all methods.

@MyGodItsFull0fStars
Copy link
Contributor Author

Hello,
okay, when I have time I can add more of these changes to this branch, which can later be merged for a major release.

Thanks for letting me know :)

@benoit-cty benoit-cty changed the title Fixed wrong return type hint and updated doc string Draft: Fixed wrong return type hint and updated doc string Mar 20, 2024
@benoit-cty benoit-cty force-pushed the fix-stop-task-signature-and-comment branch from 754cfc9 to 571bc20 Compare May 1, 2024 07:08
@SaboniAmine SaboniAmine self-assigned this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants