logrotate for /var/log/babel on ingest machines, again #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was working as long as everywhere we used it we also happened to use the `nebula::log` defined type, which includes `profile::loki`.
any manifests needing os_facts (like apt) fail without this
rrotter
force-pushed
the
ht-ingest-logrotate2
branch
from
c7fcf27 to
8916a6e
Compare
aelkiss
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #759, with the addition of explicitly
include nebula::profile::lokiinbabel_logs.pp. Assuming you wanted alloy on these hosts, that will fix the puppet failure (puppet wouldn't write the alloy drop-in because/etc/alloydidn't exist, because thealloypackage wasn't installed).