Use Cloudflare headers to set X-Client-IP #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a service is directly exposed, we set the X-Client-IP to the connecting IP address. When proxying through Cloudflare, the originating IP address is set in the CF-Connecting-IP header, which we should use for the value instead. This change also conducts a minor reordering of the template to keep the forwarded protocol next to the client IP header directive. This reordering is cosmetic only; the routing/access decisions are unchanged.
rrotter
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a service is directly exposed, we set the X-Client-IP to the connecting IP address. When proxying through Cloudflare, the originating IP address is set in the CF-Connecting-IP header, which we should use for the value instead.
This change also conducts a minor reordering of the template to keep the forwarded protocol next to the client IP header directive. This reordering is cosmetic only; the routing/access decisions are unchanged.