Upgrade PDK Preparation #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add PDK 2 to Gemfile - don't track Gemfile.lock - rearrange .gitignore to be closer to what PDK generates - add .sync.yml to correctly generate: - .gitignore - Gemfile - default_facts.yml
rrotter
force-pushed
the
upgrade_pdk2
branch
5 times, most recently
from
765a50c to
bcd883d
Compare
daaang
approved these changes
Dec 13, 2024
removed mocks were not actually used in any specs
- replace all remaininng rspec-puppet-utils mocks - remove rspec-puppet-utils from Gemfile
rrotter
force-pushed
the
upgrade_pdk2
branch
from
f9b7012 to
f0f7e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passing without puppet-rspec-utils. Running
bundle exec pdk updateat this point results in a clean upgrade that can runrake specsuccessfully on ruby 2.7 and 3.2. I'll put the actual upgrade and any rubocop/lint cleanup in another PR.