upgrade to pdk 3, ruby 3 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrotter
force-pushed
the
pdk_prep
branch
2 times, most recently
from
c8dd2e5 to
209aa95
Compare
rrotter
force-pushed
the
pdk_prep
branch
2 times, most recently
from
fa427ea to
f53e3e6
Compare
|
Removed the last commit in this PR (which added standardrb), it doesn't belong here. |
asdf is a local developer tool, so its config doesn't belong in git. OTOH, .ruby-version may be used by CI so it will remain.
- ruby 3.2 is the current ruby in puppet 8 - pdk 3.2 introduces regressions in CI - Intentional differences from pdk template: - don't include rake release tasks - don't include `networking` default facts - remove rubocop config
Merged
daaang
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to:
rake spectasks significantly introducing a ton of warnings)add standardrbthis will be another PR