Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root dotfiles #785

Merged
merged 1 commit into from
Jan 6, 2025
Merged

root dotfiles #785

merged 1 commit into from
Jan 6, 2025

Conversation

rrotter
Copy link
Member

@rrotter rrotter commented Jan 3, 2025

No description provided.

@rrotter rrotter requested review from botimer, skorner and daaang January 3, 2025 00:07
@rrotter rrotter marked this pull request as draft January 3, 2025 00:12
alias ls='ls $COLOR_OPTIONS'
alias ll='ls $COLOR_OPTIONS -l'
alias la='ls $COLOR_OPTIONS -A'
alias lla='ls $COLOR_OPTIONS -lA'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you said this was largely copied from debian/ubuntu defaults, so I'm not inclined to do much bikeshedding, but since these are meant to be convenient, I'll suggest s/-l/-lh/, since -h is almost always preferable for taking information in at a glance.

@botimer
Copy link
Member

botimer commented Jan 3, 2025 via email

@rrotter
Copy link
Member Author

rrotter commented Jan 3, 2025

  • Removed lla, that was the only item in here that wasn't lifted from the actual default /etc/skel/.bashrc or /root/.bashrc on Debian or Ubuntu.
  • Added -h to ll. I agree with @daaang. There's another -F in there for similar (imo) ergonomic reasons, but I won't go too far defending either.
  • Removed most of my editorial.

I will not edit this branch further. If there objections to what's here please feel free to add commits to this branch.

If there are no objections, then this is just waiting on confirming on Monday whether we need the odd local edits currently present on one or two servers that this commit will run over.

Copy link
Collaborator

@daaang daaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I've got used to the lack of colors, but their addition won't hurt me either, plus I'll know at a glance which things are directories. Seems good.

I have been stubbing my toe on the lack of ll probably about once weekly since 2017 (never complained since I figured it was my fault), so that alias will be a welcome addition for me. I doubt I'll use any of the others, but they won't get in my way or harm me, and I think I've seen them all before.

recurse => 'remote' and purge => false sound right to me for this.

@rrotter rrotter requested review from antmoth and umjnega January 3, 2025 23:19
@rrotter
Copy link
Member Author

rrotter commented Jan 3, 2025

imo the most important things here were:

  1. Eliminating random variation, while making people more comfortable.
  2. Longer history so ^R works reliably at the cost of like 4k of disk space.

- .bash_profile: delete this if it exists
- .profile: verbatim from Debian
- .bashrc: enable ls and grep color, ls aliases
@rrotter rrotter marked this pull request as ready for review January 6, 2025 18:35
@rrotter
Copy link
Member Author

rrotter commented Jan 6, 2025

Thanks for the feedback, everyone. Merging.

@rrotter rrotter merged commit 3d623ef into production Jan 6, 2025
2 checks passed
@rrotter rrotter deleted the root-dotfiles branch January 6, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants