Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new updates on mkdocs #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Moses-Mk
Copy link

This new updates has considered the proper arrangement of the files addressing the previous issue in our commit where by the files where not appearing on the browser after running mkdocs serve.

please try again this time. Thanks

@aliabbasjaffri
Copy link
Collaborator

@Moses-Mk can you please go through your PR and try to fix some issues? I think there are some assumptions in the documentation which are not a part of mlinfra tool.

mlinfra Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

@@ -1,75 +1,500 @@
`cloud_vm` deploys MLOps `stack` on top of Cloud provider VMs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This inline before the main heading doesn't look very nice.

@@ -1,75 +1,500 @@
`cloud_vm` deploys MLOps `stack` on top of Cloud provider VMs.
# ☁️ Cloud Infrastructure Examples
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this from Cloud Infrastructure to Cloud VM examples?


Welcome to the **Cloud Infrastructure** examples! This section contains ready-to-use configurations to help you deploy scalable MLOps stacks on cloud platforms like AWS. Each example is designed to showcase a different tool or workflow, making it easier for you to find and deploy the infrastructure that fits your needs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment for the cloud infrastructure here.

3. **Choose an Example**:
Navigate to the example you want to deploy:
```bash
cd examples/cloud_infra/dagster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no cloud_infra folder in examples path. Can you update this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh I apologize i had created that path temporarily and forgot to update it here, I will surely work on these

```

4. **Configure AWS Credentials**:
Modify the `terraform.tfvars` file to update your AWS account details. Make sure your AWS credentials are correctly configured.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why are you mentioning this terraform.tfvars file? This file is not necessary when you're deploying via mlinfra

@Moses-Mk
Copy link
Author

@Moses-Mk can you please go through your PR and try to fix some issues? I think there are some assumptions in the documentation which are not a part of mlinfra tool.

I have made the corrections as per your review. Please specify the assumptions anything specific so that I can correct it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants