Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simpler models. #28

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

kartikdutt18
Copy link
Member

Hey everyone,
Since we now have a separate repository for simple models / examples and we have also merged a model for the models repo. This PR removes the LSTM and Kaggle example since they are part of the examples repo now.
This PR checks of another task from #1.
Kindly let me know what you think.
Regards,
Kartik.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! To me this looks good. Thanks for taking the time to remove these and keep up with #1. :)

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

Copy link
Member

@KimSangYeon-DGU KimSangYeon-DGU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments from my side, thanks!

@KimSangYeon-DGU KimSangYeon-DGU merged commit cfa9d70 into mlpack:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants