clarify code ownership for ResamplingSpCVTiles and `ResamplingSpCVD…

…isc`
mlr-org · May 31, 2022 · aa8448a · aa8448a
1 parent 6be805e
commit aa8448a
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 3 deletions.
diff --git a/R/ResamplingRepeatedSpCVDisc.R b/R/ResamplingRepeatedSpCVDisc.R
@@ -122,8 +122,6 @@ ResamplingRepeatedSpCVDisc = R6Class("ResamplingRepeatedSpCVDisc",
       # declare empty list so the for-loop can write to its fields
       self$instance = vector("list", length = reps)
 
-      # k = self$param_set$values$folds
-
       for (rep in seq_len(reps)) {
         index = sample.int(nrow(coords),
           size = self$param_set$values$folds,
@@ -137,6 +135,8 @@ ResamplingRepeatedSpCVDisc = R6Class("ResamplingRepeatedSpCVDisc",
         # respective folds
         mlr3_index = 1
 
+        ### start: this part is mainly copied from sperrorest::partition_disc()
+
         for (i in index) {
           if (!is.null(self$param_set$values$buffer) |
             self$param_set$values$radius >= 0) {
@@ -165,6 +165,8 @@ ResamplingRepeatedSpCVDisc = R6Class("ResamplingRepeatedSpCVDisc",
             )
           }
 
+          ### end: this part is mainly copied from sperrorest::partition_disc()
+
           # similar result structure as in sptcv_cstf
           self$instance[[rep]]$test[[mlr3_index]] = test_sel
           self$instance[[rep]]$train[[mlr3_index]] = train_sel

diff --git a/R/ResamplingRepeatedSpCVTiles.R b/R/ResamplingRepeatedSpCVTiles.R
@@ -161,6 +161,8 @@ ResamplingRepeatedSpCVTiles = R6Class("ResamplingRepeatedSpCVTiles",
         pv$repeats = 1
       }
 
+      ### start: this part is mainly copied from sperrorest::partition_tiles()
+
       if (pv$rotation == "none") {
         phi = rep(0, length(seq_len(pv$repeats)))
       } else if (pv$rotation == "random") {
@@ -326,6 +328,8 @@ ResamplingRepeatedSpCVTiles = R6Class("ResamplingRepeatedSpCVTiles",
 
         tile = sperrorest::as.resampling(tile)
 
+        ### end: this part is mainly copied from sperrorest::partition_tiles()
+
         class(tile) == "list"
         train_inds = lapply(tile, function(x) x$train)
         test_inds = lapply(tile, function(x) x$test)

diff --git a/R/ResamplingSpCVCoords.R b/R/ResamplingSpCVCoords.R
@@ -55,7 +55,6 @@ ResamplingSpCVCoords = R6Class("ResamplingSpCVCoords",
       assert_spatial_task(task)
       groups = task$groups
 
-
       if (!is.null(groups)) {
         stopf("Grouping is not supported for spatial resampling methods")
       }

diff --git a/R/ResamplingSpCVDisc.R b/R/ResamplingSpCVDisc.R
@@ -105,6 +105,7 @@ ResamplingSpCVDisc = R6Class("ResamplingSpCVDisc",
       # respective folds
       mlr3_index = 1
 
+      ### start: this part is mainly copied from sperrorest::partition_disc()
       for (i in index) {
         if (!is.null(self$param_set$values$buffer) |
           self$param_set$values$radius >= 0) {
@@ -132,6 +133,7 @@ ResamplingSpCVDisc = R6Class("ResamplingSpCVDisc",
             wrap = TRUE
           )
         }
+        ### end: this part is mainly copied from sperrorest::partition_disc()
 
         # similar result structure as in sptcv_cstf
         self$instance$test[[mlr3_index]] = test_sel

diff --git a/R/ResamplingSpCVTiles.R b/R/ResamplingSpCVTiles.R
@@ -111,6 +111,8 @@ ResamplingSpCVTiles = R6Class("ResamplingSpCVTiles",
         pv$repeats = 1
       }
 
+      ### start: this part is mainly copied from sperrorest::partition_tiles()
+
       if (pv$rotation == "none") {
         phi = rep(0, length(seq_len(pv$repeats)))
       } else if (pv$rotation == "random") {
@@ -280,6 +282,8 @@ ResamplingSpCVTiles = R6Class("ResamplingSpCVTiles",
       }
       tile = sperrorest::as.resampling(tile)
 
+      ### end: this part is mainly copied from sperrorest::partition_tiles()
+
       class(tile) == "list"
       train_inds = lapply(tile, function(x) x$train)
       test_inds = lapply(tile, function(x) x$test)