fix: Gracefully handle errors when disabling C modules #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to
mluaso it no longer panics when unable to disable C modules.This is primarily meant for Pluto, which has sandbox options that fully disable loading C modules, which would otherwise conflict with
mluaalso trying to disable a loader that no longer exists.I'm not 100% sure if throwing the error away is the best solution, but it seems extremely unlikely that this would fail in any logical sense besides
package.loadlibor thesearchersnot existing, in which case the end goal was already reached (being unable to load any C modules).I'm happy to fix this differently if you have any other ideas!