Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking #1129

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Fix linking #1129

merged 7 commits into from
Apr 29, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Apr 28, 2024

For #1116

This PR:

  • Fixes linking images within the project creator (uses absolutePath if the image is outside the project directory)
  • Fixes remote metadata creation
  • Fixes failing project creator tests + adds more for linking / remote metadata
  • Updates the javadoc

Note: I've currently commented out the line in ImagesCreatorTest that validates the dataset json against the schema. This is due to the missing absolutePath. It can be un-commented once this is added.

Also, this doesn't currently support directly giving an s3address to the project creator (for files that are already stored remotely). This is probably best added later, as it's a new feature that wasn't in the original project creator.

@K-Meech K-Meech requested a review from tischi April 28, 2024 11:23
@K-Meech
Copy link
Contributor Author

K-Meech commented Apr 28, 2024

Here's a link to the PR to add absolutePath into the schema: mobie/mobie.github.io#110

@tischi
Copy link
Contributor

tischi commented Apr 29, 2024

Thanks a lot @K-Meech ❤️ !

I created an issue for the S3 linking: #1130

@tischi tischi merged commit d4f4682 into new-n5-merge-main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants