Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved N5 Export #184

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Improved N5 Export #184

wants to merge 1 commit into from

Conversation

tischi
Copy link
Contributor

@tischi tischi commented Feb 4, 2021

@K-Meech

I'll try here to make a list of things we want to achieve:

  • Create a class that can save an ImagePlus to N5, based on the ExportImagePlusAsN5PlugIn in bdv-fiji
    • We would copy and paste the code into this repo and modify it to
      • separate UI from functionality
      • add the option to specify a custom affine transform
      • add the option to chose the downsampling modality (avg, nearest)
  • We copy WriteSequenceToN5 from bdv-core and modify it such that the downsampling modality can be configured

In general we try to make the changes such that our work could be merged at some point into bdv-fiji and bdv-core.

What do you think?

@tischi tischi added the enhancement New feature or request label Feb 4, 2021
@K-Meech
Copy link
Collaborator

K-Meech commented Feb 4, 2021

Sounds good to me!
I'm working on ExportImagePlusAsN5Plugin at the moment, so if you could look at WriteSequencetoN5 - that'd be perfect!
Ideally we'd also make these changes for ExportImagePlusPlugin https://github.com/bigdataviewer/bigdataviewer_fiji/blob/master/src/main/java/bdv/ij/ExportImagePlusPlugIn.java and WriteSequenceToHdf5 https://github.com/bigdataviewer/bigdataviewer-core/blob/master/src/main/java/bdv/export/WriteSequenceToHdf5.java. It's not so urgent, but it'd be nice to still support hdf5. As far as I can see from the code, it is structured in an extremely similar way, so shouldn't be too hard to do.

@K-Meech K-Meech mentioned this pull request Mar 31, 2021
@KateMoreva KateMoreva changed the base branch from master to develop September 3, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants