Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts for the Annotator #384

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

tischi
Copy link
Contributor

@tischi tischi commented Jul 28, 2021

see: #352

@K-Meech

I added back the code that was in the ij-utils commit. It turns out that this commit was just adding the button but did not implement the actual keyboard listener. I vaguely remember that I had trouble getting this to work, because the annotator typically is not the focused window, because people click in the BDV window. We could implement a "global" keyboard listener, but then if people write an e-mail in between it would still listen...

@tischi tischi requested a review from K-Meech July 28, 2021 07:59
@K-Meech
Copy link
Contributor

K-Meech commented Jul 28, 2021

Ah ok - makes sense. Maybe you could just have 2 listeners (one on the annotator + one on the bdv window), to avoid the global listener? Not sure how hard this would be!

@tischi
Copy link
Contributor Author

tischi commented Jul 28, 2021

Yes, something like this. I guess that's why it was never really implemented because I found this a bit tedious 😉 , but I will give it a 2nd shot!

@tischi
Copy link
Contributor Author

tischi commented Jul 28, 2021

@KateMoreva KateMoreva changed the base branch from master to develop September 3, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants