Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init ViewFromSourceAndConverterCreator #608

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Init ViewFromSourceAndConverterCreator #608

merged 3 commits into from
Feb 21, 2022

Conversation

tischi
Copy link
Contributor

@tischi tischi commented Feb 20, 2022

No description provided.

@tischi tischi mentioned this pull request Feb 20, 2022
Draft
3 tasks
@tischi tischi requested a review from K-Meech February 21, 2022 13:31
@tischi tischi marked this pull request as ready for review February 21, 2022 13:31
@tischi
Copy link
Contributor Author

tischi commented Feb 21, 2022

Hi @K-Meech,

Could you have a look?

I would like to merge this soon, because I need it here and working with too many branches is confusing to me.

What I did so far was to add a new constructor to AffineSourceTransformer and ImageSourceDisplay. I feel this is quite handy and maybe you could also use those in your parts of the code?!

@K-Meech
Copy link
Contributor

K-Meech commented Feb 21, 2022

Looks good to me! I think just go ahead and merge :)

@tischi tischi merged commit 96ab971 into develop Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Meech K-Meech Awaiting requested review from K-Meech

Assignees

@K-Meech K-Meech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tischi @K-Meech