Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export choice_status_message, VerificationMessage and MESSAGE_INDENT #162

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Aug 16, 2023

Previously the choice_to_status_message, VerificationMessage and the MESSAGE_INDENT were private to the crate.
This prevented consumers from being able to use these in their own Verifier implementations.
These items are now publicly available for use.

@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@meowblecoinbot meowblecoinbot requested a review from a team August 16, 2023 17:26
@github-actions github-actions bot added the size/M Medium-sized PRs label Aug 16, 2023
@github-actions
Copy link

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags

@nick-mobilecoin nick-mobilecoin changed the title Whatever. Make choice_status_message and MESSAGE_INDENT public. Aug 16, 2023
@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team August 16, 2023 17:27
@nick-mobilecoin nick-mobilecoin changed the title Make choice_status_message and MESSAGE_INDENT public. Export choice_status_message, VerificationMessage and MESSAGE_INDENT Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #162 (6baddcd) into main (b791c76) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 6baddcd differs from pull request most recent head 5d2d05d. Consider uploading reports for the commit 5d2d05d to get more accurate results

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          13       13           
  Lines        4343     4343           
=======================================
  Hits         4278     4278           
  Misses         65       65           
Files Changed Coverage Δ
verifier/src/lib.rs 97.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

verifier/src/lib.rs Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin merged commit b9d9a22 into main Aug 16, 2023
21 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/missing-public-exports branch August 16, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium-sized PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants