Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Task Management #226

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Improved Task Management #226

merged 8 commits into from
Feb 5, 2025

Conversation

movchan74
Copy link
Contributor

@movchan74 movchan74 commented Feb 4, 2025 •
edited
Loading

  • Refactor Task Management endpoints. Now 5 endpoints are available: get tast, list tasks (with filters), delete tasks, count tasks (per status), retry task. Endpoints adhere to REST now.
  • All task endpoints now return extra fields like "data" and "endpoint".
  • Moved all routers into a separate directory.
  • Legacy endpoints for getting the task's status and deleting it are still available but marked as deprecated. We will remove them in a future release.
  • Added relevant tests.

Closes: #177

@movchan74 movchan74 marked this pull request as ready for review February 5, 2025 10:06
@movchan74 movchan74 requested a review from HRashidi February 5, 2025 10:06
HRashidi
HRashidi reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@HRashidi HRashidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

HRashidi
HRashidi reviewed Feb 5, 2025
View reviewed changes
aana/routers/task.py Outdated Show resolved Hide resolved
@movchan74 movchan74 requested a review from HRashidi February 5, 2025 17:38
@movchan74 movchan74 requested a review from HRashidi February 5, 2025 18:10
HRashidi
HRashidi approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@HRashidi HRashidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@movchan74 movchan74 merged commit 501e287 into main Feb 5, 2025
9 checks passed
@movchan74 movchan74 deleted the improved_task_management branch February 5, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HRashidi HRashidi HRashidi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Additional Endpoints for Task Queue
2 participants
@movchan74 @HRashidi