Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edr/getting started doc #44

Merged
merged 19 commits into from
Feb 21, 2024
Merged

Edr/getting started doc #44

merged 19 commits into from
Feb 21, 2024

Conversation

evanderiel
Copy link
Collaborator

No description provided.

@movchan74
Copy link
Contributor

Maybe we should merge it with my branch.

@evanderiel
Copy link
Collaborator Author

Which branch?

@movchan74
Copy link
Contributor

Which branch?

The one I created for the meeting we had yesterday: https://github.com/mobiusml/aana_sdk/tree/getting_started_docs

Copy link
Contributor

@movchan74 movchan74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues (mostly with the example code that isn't synchronized with the code in the text) and some suggestions.
Shall we add intro from https://github.com/mobiusml/aana_sdk/blob/getting_started_docs/docs/aana_intro.md#aana-sdk?

@evanderiel evanderiel requested a review from movchan74 February 20, 2024 05:30
@evanderiel
Copy link
Collaborator Author

I'm merging this without a new approval because the new commit is just changing poetry.lock

@evanderiel evanderiel merged commit d9a62fa into main Feb 21, 2024
1 check passed
@evanderiel evanderiel deleted the edr/getting_started_doc branch May 22, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants