Skip to content

Commit

Permalink
lib.types.string: Deprecation error instead of warning
Browse files Browse the repository at this point in the history
The type has given a warning on use since [4 years ago](03392cd336b128a1639c648baf0f6c1a1271e0d2), I think it's safe to move the deprecation to the next stage: An error instead of a warning.
  • Loading branch information
infinisil committed Aug 8, 2023
1 parent 424c26c commit c59c6b1
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions lib/types.nix
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,7 @@ rec {

# Deprecated; should not be used because it quietly concatenates
# strings, which is usually not what you want.
string = separatedString "" // {
name = "string";
deprecationMessage = "See https://github.com/NixOS/nixpkgs/pull/66346 for better alternative types.";
};
string = throw "The type `types.string` is deprecated. See https://github.com/NixOS/nixpkgs/pull/66346 for better alternative types.";

passwdEntry = entryType: addCheck entryType (str: !(hasInfix ":" str || hasInfix "\n" str)) // {
name = "passwdEntry ${entryType.name}";
Expand Down

0 comments on commit c59c6b1

Please sign in to comment.