Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: mount docker config on gha #5390

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

crazy-max
Copy link
Member

similar to moby/buildkit-bench#59 to avoid rate-limiting.

@github-actions github-actions bot added the area/hack building buildkit itself label Oct 3, 2024
@tonistiigi tonistiigi force-pushed the ci-mount-docker-config branch from 8edb942 to eed9e4b Compare January 31, 2025 02:40
@tonistiigi tonistiigi force-pushed the ci-mount-docker-config branch from eed9e4b to 3ab3e5e Compare January 31, 2025 02:43
@tonistiigi tonistiigi marked this pull request as ready for review January 31, 2025 02:43
One should not use their regular docker credentials here
but make a special config file with only public readonly
token inside.

Signed-off-by: Tonis Tiigi <[email protected]>
@tonistiigi tonistiigi force-pushed the ci-mount-docker-config branch from 3ab3e5e to 33088c1 Compare January 31, 2025 03:00
hack/test Show resolved Hide resolved
Copy link
Member Author

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonistiigi tonistiigi merged commit ff97fe1 into moby:master Feb 3, 2025
97 checks passed
@crazy-max crazy-max deleted the ci-mount-docker-config branch February 3, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants