Fix condition to allow creating console on stdio #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used stdio interactive console, two errors occurs.
checkSerials()
raise wrong error: "If StdioInteractiveConsole is set, stdio must be a TTY"To connect
cmd.Stdin
withos.Stdin
and interact with VM, os.Stdout should be terminal.But if os.Stdout is terminal,
checkSerials()
raise error that say that "must be a terminal."When I checked the previous code, it was originally
!isTerminal()
. I think, it is a typo.cmd.StdoutPipe()
is called whilecmd.Stdout
is already set: "Stdout already set"If use stdio console, cmd.Stdout could not be nil. But
cmd.StdoutPipe()
requires that cmd.Stdout must be nil.Thus, I could not use stdio console.
I used Google translate to write this PR. If any of my expressions were rude, it was not intentional, so please understand.